-
Notifications
You must be signed in to change notification settings - Fork 6k
planner: don't choose merge join unless there's hint or join key fully matched | tidb-test=pr/2493 #59933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: don't choose merge join unless there's hint or join key fully matched | tidb-test=pr/2493 #59933
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59933 +/- ##
================================================
+ Coverage 72.9169% 73.3476% +0.4307%
================================================
Files 1701 1701
Lines 469725 469767 +42
================================================
+ Hits 342509 344563 +2054
+ Misses 106094 104076 -2018
- Partials 21122 21128 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/retest |
ef95293
to
7eed650
Compare
/ok-to-test |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fixdb, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/cherrypick release-7.5-20250306-v7.5.5-1 |
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
What problem does this PR solve?
Issue Number: close #20710
Problem Summary:
What changed and how does it work?
The previous pr only checks that the left keys will be fully covered.
If left keys meet the condition while right keys do not. we can still choose the merge join automatically and put some join key as the other condition.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.