-
Notifications
You must be signed in to change notification settings - Fork 6k
domain: change @@tidb_schema_cache_size to 0 should not set the capacity to 0 #59952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: GMHDBJD, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #59952 +/- ##
================================================
+ Coverage 72.9252% 75.0379% +2.1126%
================================================
Files 1701 1749 +48
Lines 469722 480845 +11123
================================================
+ Hits 342546 360816 +18270
+ Misses 106059 97407 -8652
- Partials 21117 22622 +1505
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/retest |
@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@tiancaiamao: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/retest |
What problem does this PR solve?
Issue Number: close #59949
Problem Summary:
Change schema cache size take effect immediately, but switch from v2 to v1 take effect after a schema reload.
This cause a bug that during the period when @@tidb_schema_cache_size is set to 0, but the implement have not change to v1, the schame cache hit rate become 0.
What changed and how does it work?
When set @@tidb_schema_cache_size to 0, do not change the schema cache capacity.
Check List
Tests
Now the result is expected, there is no data after changing from v2 to v1:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.