-
Notifications
You must be signed in to change notification settings - Fork 6k
planner: fix wrong HashAgg estrows for inner operator of index join #60071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #60071 +/- ##
================================================
+ Coverage 73.1879% 73.6540% +0.4661%
================================================
Files 1708 1708
Lines 471910 472596 +686
================================================
+ Hits 345381 348086 +2705
+ Misses 105318 103328 -1990
+ Partials 21211 21182 -29
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
The stream agg also should be changed together |
I have updated it. |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-8.5 |
Signed-off-by: ti-chi-bot <[email protected]>
@hawkingrei: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #59902
Problem Summary:
What changed and how does it work?
in the
constructIndexJoinInnerSideTaskWithAggCheck
, we forget to transfer the parents stats by the child stats.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.