Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #60116

What problem does this PR solve?

Issue Number: close #60105
ref #60085

Problem Summary:
A scan region issue was identified in pingcap/tidb#60085

What changed and how does it work?

  • Temporarily disabled the PD follower handle to ensure that region scanning functions correctly when restoring from a checkpoint.
  • Fixed a panic issue caused by a missing nil check during checkpoint removal.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1 labels Mar 17, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 17, 2025
@Tristan1900
Copy link
Contributor

/approve

@Tristan1900
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 17, 2025
Copy link

ti-chi-bot bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Tristan1900

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Mar 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-17 14:30:38.57977509 +0000 UTC m=+279532.264011171: ☑️ agreed by 3pointer.
  • 2025-03-17 14:40:04.627863131 +0000 UTC m=+280098.312099224: ☑️ agreed by Tristan1900.

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-9.0-beta.1@7b4717b). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             release-9.0-beta.1     #60128   +/-   ##
=======================================================
  Coverage                      ?   74.8588%           
=======================================================
  Files                         ?       1718           
  Lines                         ?     471208           
  Branches                      ?          0           
=======================================================
  Hits                          ?     352741           
  Misses                        ?      96703           
  Partials                      ?      21764           
Flag Coverage Δ
integration 46.4721% <40.0000%> (?)
unit 72.5381% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 62.3190% <0.0000%> (?)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@3pointer
Copy link
Contributor

/test unit-test

Copy link

tiprow bot commented Mar 17, 2025

@3pointer: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@3pointer
Copy link
Contributor

/test unit-test

Copy link

tiprow bot commented Mar 18, 2025

@3pointer: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Mar 20, 2025
@ti-chi-bot ti-chi-bot bot merged commit a5ca5f3 into pingcap:release-9.0-beta.1 Mar 20, 2025
27 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-9.0-beta.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants