Skip to content

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Mar 20, 2025

What problem does this PR solve?

Issue Number: close #60195

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

The field type in the network protocol for blob types was changed to match MySQL.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2025
Copy link

tiprow bot commented Mar 20, 2025

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dveeden
Copy link
Contributor Author

dveeden commented Mar 20, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Mar 20, 2025
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5474%. Comparing base (37855f9) to head (6c5976b).
Report is 639 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60196        +/-   ##
================================================
+ Coverage   73.1457%   73.5474%   +0.4016%     
================================================
  Files          1708       1708                
  Lines        471683     471818       +135     
================================================
+ Hits         345016     347010      +1994     
+ Misses       105469     103592      -1877     
- Partials      21198      21216        +18     
Flag Coverage Δ
integration 42.7697% <100.0000%> (?)
unit 72.3267% <0.0000%> (-0.0251%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 47.2537% <ø> (+0.0416%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 24, 2025
Copy link

ti-chi-bot bot commented Mar 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [hawkingrei,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 24, 2025
Copy link

ti-chi-bot bot commented Mar 24, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-24 06:32:15.562412654 +0000 UTC m=+855629.246648735: ☑️ agreed by hawkingrei.
  • 2025-03-24 10:40:23.855857655 +0000 UTC m=+870517.540093749: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 9836134 into pingcap:master Mar 24, 2025
20 of 24 checks passed
disksing pushed a commit to oh-my-tidb/tidb that referenced this pull request Mar 27, 2025
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jul 8, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #62281.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field type compatibility for blob types in MySQL protocol
4 participants