planner: calculate plan_digest in place when fetching plan exec info from stmt_stats in `SHOW PLAN FOR <SQL>` #60273

qw4990 · 2025-03-26T09:36:25Z

What problem does this PR solve?

Issue Number: ref #60148

Problem Summary: planner: calculate plan_digest in place when fetching plan exec info from stmt_stats in SHOW PLAN FOR <SQL>

What changed and how does it work?

Due to some historical reason, binding.plan_digest might be empty, which prevents us from joining mysql.bind_info and stmt_stats to get bindings' corresponding plan execution info.

For example, if a binding is created manually like create global binding using select ..., then its plan_digest is empty by default.

This PR calculates plan_digest for bindings in place when trying to fetch exec info for a binding. All logic is behind getBindingPlanDigest.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2025-03-26T09:36:42Z

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

codecov · 2025-03-26T10:00:49Z

Codecov Report

Attention: Patch coverage is 78.46154% with 14 lines in your changes missing coverage. Please review.

Project coverage is 75.0402%. Comparing base (7c0c2b1) to head (bdb6a64).
Report is 6 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #60273        +/-   ##
================================================
+ Coverage   73.1221%   75.0402%   +1.9180%     
================================================
  Files          1710       1756        +46     
  Lines        472557     482549      +9992     
================================================
+ Hits         345544     362106     +16562     
+ Misses       105730      97765      -7965     
- Partials      21283      22678      +1395

Flag	Coverage Δ
integration	`49.0266% <1.5384%> (?)`
unit	`72.4895% <78.4615%> (+0.1600%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.6910% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`62.3451% <ø> (+15.1139%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

qw4990 · 2025-03-26T11:38:22Z

/test unit-test

tiprow · 2025-03-26T11:38:44Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei · 2025-03-27T02:19:49Z

/test all

henrybw

Seems fine to me.

henrybw · 2025-03-27T03:39:58Z

pkg/bindinfo/binding_auto.go

+		if planDigest == "" {
+			_ = callWithSCtx(ba.sPool, false, func(sctx sessionctx.Context) error {
+				planDigest = getBindingPlanDigest(sctx, binding.Db, binding.BindSQL)
+				return nil
+			})
+		}


Since generating a new plan digest seems like an expensive operation (invoking the planner and optimizing the plan), maybe we should log an info message when we do this? Just a suggestion, though: I'm fine with not logging if you think that makes more sense.

Got it, but no logging seems OK since the generation operation is a in-memory operation, which shouldn't take a long time, and SHOW PLAN FOR <SQL> should be a low-frequently operation, so it should be OK here without any logging.

ti-chi-bot · 2025-03-27T03:44:33Z

@henrybw: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Seems fine to me.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot · 2025-03-27T06:18:58Z

[LGTM Timeline notifier]

Timeline:

2025-03-27 05:57:23.388864265 +0000 UTC m=+1112737.073100360: ☑️ agreed by time-and-fate.
2025-03-27 06:18:57.492093009 +0000 UTC m=+1114031.176329105: ☑️ agreed by hawkingrei.

ti-chi-bot · 2025-03-27T06:50:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, henrybw, tangenta, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/bindinfo/OWNERS~~ [hawkingrei,time-and-fate]
~~pkg/infoschema/OWNERS~~ [tangenta]
~~pkg/planner/OWNERS~~ [hawkingrei,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hawkingrei · 2025-03-27T07:31:13Z

/retest

qw4990 · 2025-03-28T08:15:53Z

/test unit-test

tiprow · 2025-03-28T08:16:16Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2025-03-28T09:01:36Z

/test unit-test

tiprow · 2025-03-28T09:01:58Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2025-03-28T11:26:41Z

/test mysql-test

tiprow · 2025-03-28T11:27:03Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2025-03-28T11:46:54Z

/test check-dev2

tiprow · 2025-03-28T11:47:17Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2025-03-29T01:20:01Z

/retest

tiprow · 2025-03-29T01:20:23Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2025-03-29T01:23:03Z

/ok-to-test

qw4990 · 2025-03-29T01:23:24Z

/retest

tiprow · 2025-03-29T01:23:25Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-03-29T01:23:46Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2025-03-29T01:23:56Z

/test check_dev_2

tiprow · 2025-03-29T01:24:17Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check_dev_2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

terry1purcell · 2025-03-29T02:05:08Z

/ok-to-test

tiprow · 2025-03-29T02:05:30Z

@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei · 2025-03-29T03:18:40Z

/ok-to-test

hawkingrei · 2025-03-29T03:18:51Z

/retest

qw4990 · 2025-03-31T01:55:18Z

/retest

tiprow · 2025-03-31T01:55:40Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2025-03-31T02:59:47Z

/test check-dev2

tiprow · 2025-03-31T03:00:08Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

qw4990 · 2025-03-31T03:50:13Z

/test unit-test

tiprow · 2025-03-31T03:50:36Z

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…from stmt_stats in `SHOW PLAN FOR <SQL>` (pingcap#60273) ref pingcap#60148

qw4990 added 3 commits March 26, 2025 17:29

fixup

33ff623

Merge remote-tracking branch 'upstream/master' into show-plan-digest

ea9ae1b

fixup

2ce14c2

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 26, 2025

qw4990 requested a review from time-and-fate March 26, 2025 09:36

fixup

e59367a

fixup

cf0c899

henrybw approved these changes Mar 27, 2025

View reviewed changes

time-and-fate approved these changes Mar 27, 2025

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 27, 2025

qw4990 added 2 commits March 27, 2025 14:11

Merge remote-tracking branch 'upstream/master' into show-plan-digest

573ab4e

fixup

7fd0187

hawkingrei approved these changes Mar 27, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 27, 2025

fixup

9a77ad6

hawkingrei approved these changes Mar 27, 2025

View reviewed changes

tangenta approved these changes Mar 27, 2025

View reviewed changes

ti-chi-bot bot added the approved label Mar 27, 2025

qw4990 added 2 commits March 28, 2025 19:06

fixup

16c1c10

fixup

bdb6a64

ti-chi-bot bot merged commit 446952c into pingcap:master Mar 31, 2025
26 checks passed

zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025

planner: calculate plan_digest in place when fetching plan exec info …

a407b9d

…from stmt_stats in `SHOW PLAN FOR <SQL>` (pingcap#60273) ref pingcap#60148

planner: calculate plan_digest in place when fetching plan exec info from stmt_stats in SHOW PLAN FOR <SQL> #60273

planner: calculate plan_digest in place when fetching plan exec info from stmt_stats in SHOW PLAN FOR <SQL> #60273

Uh oh!

Conversation

qw4990 commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

tiprow bot commented Mar 26, 2025

Uh oh!

codecov bot commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

qw4990 commented Mar 26, 2025

Uh oh!

tiprow bot commented Mar 26, 2025

Uh oh!

hawkingrei commented Mar 27, 2025

Uh oh!

henrybw left a comment

Choose a reason for hiding this comment

Uh oh!

henrybw Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

qw4990 Mar 27, 2025

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Mar 27, 2025

Uh oh!

ti-chi-bot bot commented Mar 27, 2025

[LGTM Timeline notifier]

Uh oh!

ti-chi-bot bot commented Mar 27, 2025

Uh oh!

hawkingrei commented Mar 27, 2025

Uh oh!

qw4990 commented Mar 28, 2025

Uh oh!

tiprow bot commented Mar 28, 2025

Uh oh!

qw4990 commented Mar 28, 2025

Uh oh!

tiprow bot commented Mar 28, 2025

Uh oh!

qw4990 commented Mar 28, 2025

Uh oh!

tiprow bot commented Mar 28, 2025

Uh oh!

qw4990 commented Mar 28, 2025

Uh oh!

tiprow bot commented Mar 28, 2025

Uh oh!

qw4990 commented Mar 29, 2025

Uh oh!

tiprow bot commented Mar 29, 2025

Uh oh!

qw4990 commented Mar 29, 2025

Uh oh!

qw4990 commented Mar 29, 2025

Uh oh!

tiprow bot commented Mar 29, 2025

Uh oh!

tiprow bot commented Mar 29, 2025

Uh oh!

qw4990 commented Mar 29, 2025

Uh oh!

tiprow bot commented Mar 29, 2025

Uh oh!

terry1purcell commented Mar 29, 2025

Uh oh!

tiprow bot commented Mar 29, 2025

Uh oh!

hawkingrei commented Mar 29, 2025

Uh oh!

hawkingrei commented Mar 29, 2025

planner: calculate plan_digest in place when fetching plan exec info from stmt_stats in `SHOW PLAN FOR <SQL>` #60273

planner: calculate plan_digest in place when fetching plan exec info from stmt_stats in `SHOW PLAN FOR <SQL>` #60273

qw4990 commented Mar 26, 2025 •

edited

Loading

codecov bot commented Mar 26, 2025 •

edited

Loading