Skip to content

Conversation

djshow832
Copy link
Contributor

@djshow832 djshow832 commented Mar 26, 2025

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:
#57179 updates the order of setting etcdcli key prefix and creating ddl owner manager. After the change, the etcdcli of ddl owner manager doesn't have the keyspace prefix.
When bootstrapping, the DDL owner is occupied by another TiDB and this TiDB keeps in the loop of bootstrap.

What changed and how does it work?

Set the prefix before creating the ddl owner.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 26, 2025
Copy link

ti-chi-bot bot commented Mar 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gmhdbjd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2025
Copy link

tiprow bot commented Mar 26, 2025

Hi @djshow832. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@djshow832 djshow832 merged commit b00c6ae into pingcap:dedicated Mar 26, 2025
1 of 2 checks passed
@djshow832 djshow832 deleted the fix_ddl_owner branch March 26, 2025 15:19
@djshow832
Copy link
Contributor Author

The PR to the master: #60403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant