Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #58473

What problem does this PR solve?

Issue Number: close #58405

Problem Summary:

The labels of TiDB are stored within a static structure, meanwhile TiDB have update-label API. Before this PR, the way TiDB handles the mutations of labels have data-race risk.

What changed and how does it work?

Refactor the ServerInfo into static and dynamic sections and fix the data race by atomic operations.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Mar 27, 2025
@ti-chi-bot
Copy link
Member Author

@you06 This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 27, 2025
Signed-off-by: ti-chi-bot <[email protected]>

resolve conflict

Signed-off-by: you06 <[email protected]>
@you06 you06 force-pushed the cherry-pick-58473-to-release-8.1 branch from cb2a705 to 5795ad2 Compare March 27, 2025 06:56
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 27, 2025
you06 added 2 commits March 27, 2025 16:30
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
@you06
Copy link
Contributor

you06 commented Mar 27, 2025

/retest

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@9679a3f). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #60293   +/-   ##
================================================
  Coverage               ?   71.2396%           
================================================
  Files                  ?       1468           
  Lines                  ?     424161           
  Branches               ?          0           
================================================
  Hits                   ?     302171           
  Misses                 ?     101473           
  Partials               ?      20517           
Flag Coverage Δ
unit 71.2396% <88.8888%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.3961% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 9, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 9, 2025
Copy link

ti-chi-bot bot commented Apr 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-09 06:17:39.254683222 +0000 UTC m=+2237152.938919317: ☑️ agreed by lcwangchao.
  • 2025-04-09 06:48:20.72028318 +0000 UTC m=+2238994.404519288: ☑️ agreed by lance6716.

Copy link

ti-chi-bot bot commented Apr 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, lance6716, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 16, 2025
@you06
Copy link
Contributor

you06 commented Apr 16, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 23, 2025
@ti-chi-bot ti-chi-bot bot merged commit 2c55e79 into pingcap:release-8.1 Apr 23, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants