-
Notifications
You must be signed in to change notification settings - Fork 6k
infosync: refactor server config into dynamic and static sections (#58473) #60293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infosync: refactor server config into dynamic and static sections (#58473) #60293
Conversation
@you06 This PR has conflicts, I have hold it. |
Signed-off-by: ti-chi-bot <[email protected]> resolve conflict Signed-off-by: you06 <[email protected]>
cb2a705
to
5795ad2
Compare
Signed-off-by: you06 <[email protected]>
Signed-off-by: you06 <[email protected]>
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #60293 +/- ##
================================================
Coverage ? 71.2396%
================================================
Files ? 1468
Lines ? 424161
Branches ? 0
================================================
Hits ? 302171
Misses ? 101473
Partials ? 20517
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, lance6716, lcwangchao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
This is an automated cherry-pick of #58473
What problem does this PR solve?
Issue Number: close #58405
Problem Summary:
The labels of TiDB are stored within a static structure, meanwhile TiDB have update-label API. Before this PR, the way TiDB handles the mutations of labels have data-race risk.
What changed and how does it work?
Refactor the
ServerInfo
into static and dynamic sections and fix the data race by atomic operations.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.