Skip to content

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Mar 27, 2025

What problem does this PR solve?

Issue Number: close #60085

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

When the traffic is reduced, the state of sync can always be synchronized.

image

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Enable pd_enable_follower_handle_region during BR restore

Copy link

ti-chi-bot bot commented Mar 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 27, 2025
Copy link

tiprow bot commented Mar 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 27, 2025
@okJiang okJiang changed the title [for test]*: Revert 60116 br: enable follower handler again Apr 21, 2025
@okJiang okJiang marked this pull request as ready for review April 21, 2025 08:36
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2025
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Project coverage is 75.4856%. Comparing base (8a1ee5d) to head (a52f6fc).
Report is 20 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60301        +/-   ##
================================================
+ Coverage   73.1532%   75.4856%   +2.3323%     
================================================
  Files          1725       1748        +23     
  Lines        477917     491541     +13624     
================================================
+ Hits         349612     371043     +21431     
+ Misses       106876      97761      -9115     
- Partials      21429      22737      +1308     
Flag Coverage Δ
integration 49.4387% <45.4545%> (?)
unit 72.9819% <45.4545%> (+0.6355%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 62.4580% <59.0909%> (+14.8856%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

okJiang added 2 commits May 19, 2025 14:05
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
@okJiang
Copy link
Member Author

okJiang commented May 19, 2025

/retest

@okJiang
Copy link
Member Author

okJiang commented May 20, 2025

/cc @3pointer

@ti-chi-bot ti-chi-bot bot requested a review from 3pointer May 20, 2025 09:28
@okJiang
Copy link
Member Author

okJiang commented May 21, 2025

/cc @3pointer @YuJuncen

@ti-chi-bot ti-chi-bot bot requested a review from YuJuncen May 21, 2025 11:02
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 22, 2025
Copy link

ti-chi-bot bot commented May 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, GMHDBJD

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 22, 2025
Copy link

ti-chi-bot bot commented May 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-22 05:42:02.027354461 +0000 UTC m=+71026.444414036: ☑️ agreed by 3pointer.
  • 2025-05-22 06:47:40.079450233 +0000 UTC m=+74964.496509847: ☑️ agreed by GMHDBJD.

@okJiang
Copy link
Member Author

okJiang commented May 22, 2025

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels May 22, 2025
@okJiang
Copy link
Member Author

okJiang commented May 22, 2025

/retest

2 similar comments
@okJiang
Copy link
Member Author

okJiang commented May 22, 2025

/retest

@okJiang
Copy link
Member Author

okJiang commented May 22, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit e9853fe into pingcap:master May 22, 2025
28 of 30 checks passed
@okJiang okJiang deleted the revert-60116 branch May 23, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to scan regions when using Follower Handle
3 participants