-
Notifications
You must be signed in to change notification settings - Fork 6k
ddl: Fix ddl owner doesn't use etcd keyspace prefix (#60403) #60501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.5
Are you sure you want to change the base?
ddl: Fix ddl owner doesn't use etcd keyspace prefix (#60403) #60501
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
@djshow832 This PR has conflicts, I have hold it. |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #60501 +/- ##
================================================
Coverage ? 42.8870%
================================================
Files ? 190
Lines ? 31098
Branches ? 0
================================================
Hits ? 13337
Misses ? 15928
Partials ? 1833
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This is an automated cherry-pick of #60403
What problem does this PR solve?
Issue Number: close #60401
Problem Summary:
Previously, the etcdCli used for DDL owner was created by the domain with a keyspace prefix, so that each keyspace has a separate DDL owner.
However, in #57179, the global DDL owner creates etcdCli by itself without the keyspace prefix, so all the keyspaces share the same DDL owner. When bootstrapping, the DDL owner is occupied by another TiDB, and this TiDB keeps in the loop of the bootstrap.
What changed and how does it work?
Set the etcdCli prefix before creating the DDL owner.
Check List
Tests
test
test
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.