-
Notifications
You must be signed in to change notification settings - Fork 6k
planner: fix the issue that the type of BatchGet
with multiple columns is incorrect
#60524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rrect Signed-off-by: Yang Keao <[email protected]>
@YangKeao: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #60524 +/- ##
================================================
+ Coverage 73.1090% 73.5585% +0.4494%
================================================
Files 1714 1714
Lines 474584 477405 +2821
================================================
+ Hits 346964 351172 +4208
+ Misses 106277 104891 -1386
+ Partials 21343 21342 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Defined2014, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
…mns is incorrect (pingcap#60524) close pingcap#60523
…mns is incorrect (pingcap#60524) close pingcap#60523
What problem does this PR solve?
Issue Number: close #60523
Problem Summary:
Some branches of
BatchGet
don't convert the type of parameters, and make it fail to select correct rows. Some branches are good. Ref #32534What changed and how does it work?
pairs
.values
to be the result ofgetPointGetValue
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.