Skip to content

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Apr 22, 2025

What problem does this PR solve?

Issue Number: close #60701

Problem Summary:

What changed and how does it work?

1、 latin1_bin, utf8mb4_bin, utf8_bin should be the same collate which has the same comparison method.

2、 merge the same code in the expressionRewriter.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

collate: latin1_bin has the same collate with utf8mb4_bin,utf8_bin

collate: latin1_bin   与 utf8mb4_bin, utf8_bin 的比较方式相同

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 22, 2025
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked labels Apr 22, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 22, 2025
Copy link

ti-chi-bot bot commented Apr 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, Defined2014

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 22, 2025
Copy link

ti-chi-bot bot commented Apr 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-22 09:44:51.01448195 +0000 UTC m=+348834.826272329: ☑️ agreed by Defined2014.
  • 2025-04-22 10:03:20.646131977 +0000 UTC m=+349944.457922358: ☑️ agreed by AilinKid.

Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5340%. Comparing base (634e6ab) to head (9f4a8a4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60702        +/-   ##
================================================
+ Coverage   73.1298%   73.5340%   +0.4042%     
================================================
  Files          1716       1716                
  Lines        475628     475664        +36     
================================================
+ Hits         347826     349775      +1949     
+ Misses       106416     104496      -1920     
- Partials      21386      21393         +7     
Flag Coverage Δ
integration 42.8429% <100.0000%> (?)
unit 72.3484% <100.0000%> (+0.0010%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6553% <ø> (ø)
parser ∅ <ø> (∅)
br 47.4213% <ø> (-0.0277%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot merged commit 9331aea into pingcap:master Apr 22, 2025
22 checks passed
@hawkingrei hawkingrei deleted the 60701 branch April 22, 2025 10:26
@hawkingrei
Copy link
Member Author

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #60708.
But this PR has conflicts, please resolve them!

In response to this:

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 22, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 22, 2025
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #60709.
But this PR has conflicts, please resolve them!

In response to this:

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.5: #60710.

In response to this:

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collation 'latin1_bin' Causes Changes in Query Execution Plan
4 participants