-
Notifications
You must be signed in to change notification settings - Fork 6k
br: fix a PromQL syntax error #60705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: BornChanger <[email protected]>
Hi @BornChanger. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@BornChanger: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so. In response to removing label named needs-1-more-lgtm. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #60705 +/- ##
================================================
+ Coverage 73.1298% 74.6645% +1.5346%
================================================
Files 1716 1732 +16
Lines 475628 475732 +104
================================================
+ Hits 347826 355203 +7377
+ Misses 106416 98450 -7966
- Partials 21386 22079 +693
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, hawkingrei, joccau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #60212
Problem Summary:
fix a promql syntax issue in backup&restore panel. As a workaround, please goto tikv panel to check br related metrics.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.