-
Notifications
You must be signed in to change notification settings - Fork 6k
*: Support building FULLTEXT index #60720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #60720 +/- ##
================================================
+ Coverage 73.1447% 75.0775% +1.9328%
================================================
Files 1716 1764 +48
Lines 475657 487247 +11590
================================================
+ Hits 347918 365813 +17895
+ Misses 106376 98696 -7680
- Partials 21363 22738 +1375
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
switch indexOptions.Tp { | ||
case ast.IndexTypeVector, ast.IndexTypeInverted: | ||
// Accepted | ||
case ast.IndexTypeFulltext: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which field do we use to check the storage that this index uses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PM has not decided the user behavior of TiCI yet, so it is not in this PR. This PR only covers necessary parts to use FTS using TiFlash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to latest discussion with PM, all columnar indexes (FTS, Vector, Inverted) will have an "advanced mode" parameter. When advanced mode is set, TiCI will be used (and required). When it is not set, TiFlash will be used (and required).
Advanced mode will be added later, because currently there lacks a syntax to specify parameter for columnar indexes. This will be implemented by @Lloyd-Pottiger
Signed-off-by: Wish <[email protected]>
The expression part LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need document PR for this later
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, winoros, XuHuaiyu, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #1793
Problem Summary:
What changed and how does it work?
This PR adds complete support of creating table and inserting data using a FullText index, with latest TiFlash nightly.
This PR does not support reading from FullText index (which will be included in later PRs).
Reading will simply fail:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.