planner,indexjoin: Fix the panic of indexjoin + streamagg #60852
Conversation
ti-chi-bot
bot
added
release-note
|
Hi @elsa0520. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #60852 +/- ##
================================================
+ Coverage 73.1007% 73.2882% +0.1875%
================================================
Files 1714 1721 +7
Lines 474901 489650 +14749
================================================
+ Hits 347156 358856 +11700
- Misses 106388 109368 +2980
- Partials 21357 21426 +69
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| if dsCopTask.tablePlan != nil { | ||
| physicalTableScan, _ = dsCopTask.tablePlan.(*PhysicalTableScan) | ||
| if physicalTableScan == nil && len(dsCopTask.tablePlan.Children()) == 1 { | ||
| physicalTableScan, _ = dsCopTask.tablePlan.Children()[0].(*PhysicalTableScan) | ||
| } |
There was a problem hiding this comment.
Is there any other case? Projection or UnionScan?
There was a problem hiding this comment.
For now, there is no logic in the code.
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
Co-authored-by: Yiding Cui <[email protected]>
Co-authored-by: Yiding Cui <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qw4990, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/test mysql-test |
|
/test check-dev2 |
|
@elsa0520: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@elsa0520: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cheery-pick release-8.5 |
|
/cherry-pick release-8.5 |
|
@elsa0520: once the present PR merges, I will cherry-pick it on top of release-8.5 in the new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #60297
Problem Summary:
What changed and how does it work?
The "indexjoin + streamagg + indexlookup + nocommonhandle" will trigger a panic in ISSUE.
The root cause is that when building the stream agg and push it into coptask, tidb miss the handlecolumns on the coptask and double read tablescan side.
The reason why the reset cop task needs to be specially modified here is that:
All reset code is copied from the logic when keep order is true in function constructDS2IndexScanTask.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.