Skip to content

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented May 6, 2025

What problem does this PR solve?

Issue Number: close #60978

Problem Summary:
the count of stats_meta is zero if backup has no checksum

What changed and how does it work?

get the count of stats_meta by collecting the files instead of total kvs of table.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels May 6, 2025
Copy link

tiprow bot commented May 6, 2025

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Jianjun Liao <[email protected]>
Copy link

codecov bot commented May 6, 2025

Codecov Report

❌ Patch coverage is 55.76923% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.6861%. Comparing base (41045f1) to head (07ff254).
⚠️ Report is 687 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60979        +/-   ##
================================================
+ Coverage   73.1476%   74.6861%   +1.5384%     
================================================
  Files          1724       1724                
  Lines        477139     477201        +62     
================================================
+ Hits         349016     356403      +7387     
+ Misses       106718      98680      -8038     
- Partials      21405      22118       +713     
Flag Coverage Δ
integration 46.0222% <55.7692%> (?)
unit 72.3733% <55.7692%> (-0.0048%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 62.5301% <55.7692%> (+14.9659%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Leavrth added 2 commits May 7, 2025 10:51
Signed-off-by: Jianjun Liao <[email protected]>
Signed-off-by: Jianjun Liao <[email protected]>
@Leavrth
Copy link
Contributor Author

Leavrth commented May 7, 2025

/retest

Copy link

tiprow bot commented May 7, 2025

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 14, 2025
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 14, 2025
@Leavrth
Copy link
Contributor Author

Leavrth commented May 14, 2025

/retest

Copy link

tiprow bot commented May 14, 2025

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 14, 2025
Copy link

ti-chi-bot bot commented May 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-14 02:55:05.903583078 +0000 UTC m=+500172.051544319: ☑️ agreed by 3pointer.
  • 2025-05-14 05:33:03.4547114 +0000 UTC m=+509649.602672618: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot merged commit 19cc638 into pingcap:master May 14, 2025
28 of 33 checks passed
@BornChanger BornChanger added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Aug 29, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 29, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #63284.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the count of stats_meta is zero when restore if backup has no checksum
4 participants