-
Notifications
You must be signed in to change notification settings - Fork 6k
executor: Remove useless error logs for indexLoopUp executor when context canceled #61073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: yibin87 <[email protected]>
Hi @yibin87. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #61073 +/- ##
================================================
+ Coverage 73.1387% 73.5967% +0.4579%
================================================
Files 1724 1724
Lines 477000 478478 +1478
================================================
+ Hits 348872 352144 +3272
+ Misses 106705 104891 -1814
- Partials 21423 21443 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XuHuaiyu, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #61072
Problem Summary:
Problem described in #61072
What changed and how does it work?
In this PR, when index/table work failed, we first check if context is cancelled. And only log errors when context is not cancelled. Doesn't use WithCancelCause function to pass cancel cause here, since the actual root cause is limit executor quit quitely, by returning empty data.
Check List
Tests
Use tpch, sf=1 benchmark, add index for orders table:
alter table orders add index(o_orderdate);
Then execute the following sql and check tidb.log to see if "table reader fetch next chunk failed" log doesn't exists any more:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.