Skip to content

Conversation

zimulala
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #61095
Related PR: pingcap/tipb#363

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 13, 2025
Copy link

tiprow bot commented May 13, 2025

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 13, 2025
@pingcap pingcap deleted a comment from ti-chi-bot bot May 13, 2025
@zimulala zimulala force-pushed the zimuxia/resource-group-tag branch from d3d1af7 to 4cabe52 Compare May 13, 2025 12:45
@pingcap pingcap deleted a comment from ti-chi-bot bot May 13, 2025
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.8045%. Comparing base (61e061e) to head (bfd448d).
Report is 32 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61096        +/-   ##
================================================
+ Coverage   73.1447%   75.8045%   +2.6597%     
================================================
  Files          1724       1747        +23     
  Lines        477109     499345     +22236     
================================================
+ Hits         348980     378526     +29546     
+ Misses       106725      97952      -8773     
- Partials      21404      22867      +1463     
Flag Coverage Δ
integration 50.0458% <47.0588%> (?)
unit 73.1908% <58.8235%> (+0.8243%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 64.5567% <ø> (+17.0084%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pingcap pingcap deleted a comment from ti-chi-bot bot May 14, 2025
Copy link

tiprow bot commented May 14, 2025

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign ailinkid, amyangfei, bb7133, c4pt0r, cbcwestwolf, chrysan, csuzhangxc, dsdashun, dveeden, ekexium, elsa0520, gozssky, guo-shaoge, hanfei1991, hicqu, hongyunyan, jackysp, july2993, kennytm, leoppro, little-wallace, lysu, maxshuang, myonkeminta, okjiang, overvenus, rleungx, sticnarf, sunrunaway, time-and-fate, tisonkun, winkyao, wjhuang2016, zanmato1984, zz-jason for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

The recommendation algorithm is wrong, but it does not affect the actual effect. I will fix it.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 14, 2025
@pingcap pingcap deleted a comment from ti-chi-bot bot May 14, 2025
@pingcap pingcap deleted a comment from tiprow bot May 14, 2025
@zimulala zimulala force-pushed the zimuxia/resource-group-tag branch from 105c222 to bfd448d Compare May 14, 2025 07:43
@pingcap pingcap deleted a comment from ti-chi-bot bot May 14, 2025
@zimulala zimulala requested a review from XuHuaiyu May 14, 2025 09:45
@zimulala
Copy link
Contributor Author

/retest

@pingcap pingcap deleted a comment from ti-chi-bot bot May 15, 2025
Copy link

tiprow bot commented May 15, 2025

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zimulala
Copy link
Contributor Author

/retest

@pingcap pingcap deleted a comment from ti-chi-bot bot May 16, 2025
Copy link

tiprow bot commented May 16, 2025

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 16, 2025
Copy link

ti-chi-bot bot commented May 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-14 04:54:45.944935874 +0000 UTC m=+507352.092897092: ☑️ agreed by hawkingrei.
  • 2025-05-16 10:02:03.092298331 +0000 UTC m=+106889.348195749: ☑️ agreed by XuHuaiyu.

@zimulala
Copy link
Contributor Author

PTAL @tangenta @wjhuang2016

@zimulala
Copy link
Contributor Author

PTAL @bb7133

@zimulala zimulala requested a review from bb7133 May 20, 2025 02:29
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented May 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, hawkingrei, tangenta, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 20, 2025
@zimulala
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented May 20, 2025

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit a1b06fb into pingcap:master May 20, 2025
27 checks passed
@zimulala zimulala deleted the zimuxia/resource-group-tag branch May 20, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ResourceGroupTag carrying keyspace info and passing it to next-gen TiKV
6 participants