Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #61196

What problem does this PR solve?

Issue Number: close #61155

Problem Summary:

When we use the cost trace's explain, it will calculate the cost twice. Unfortunately, when calculating secondly, the row count has been polluted by the first.

the first calculation:

1500000000*math.log2(46.17)*11.6+10000*math.log2(46.17)*11.6 = 96203219945.10272

1500000000 will become the 5.645217633333338e+07, because postOptimize‘s
tryEnableLateMaterialization can change the row count in the first plan generate.

func PushedDown(sel *PhysicalSelection, ts *PhysicalTableScan, selectedConds []expression.Expression, selectedSelectivity float64) {
// remove the pushed down conditions from selection
removeSpecificExprsFromSelection(sel, selectedConds)
// add the pushed down conditions to table scan
ts.LateMaterializationFilterCondition = selectedConds
// Update the row count of table scan after pushing down the conditions.
ts.StatsInfo().RowCount *= selectedSelectivity
}

the second calculation:

5.645217633333338e+07*math.log2(46.17)*11.6+10000*math.log2(46.17)*11.6 = 3621204637.5523133

So two formats have different costs.

What changed and how does it work?

Generate the cost trace in the first calculation. Remove the second calculation.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

planner: fix get wrong cost with cost tracer

修复使用 cost tracer 得到不正确的 cost 值

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels May 20, 2025
@ti-chi-bot
Copy link
Member Author

@hawkingrei This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 20, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 19, 2025
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.5@c6468fb). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #61218   +/-   ##
================================================
  Coverage               ?   57.1221%           
================================================
  Files                  ?       1777           
  Lines                  ?     630621           
  Branches               ?          0           
================================================
  Hits                   ?     360224           
  Misses                 ?     246179           
  Partials               ?      24218           
Flag Coverage Δ
integration 37.0281% <100.0000%> (?)
unit 72.7531% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9278% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.6880% <0.0000%> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 8, 2025
@hawkingrei
Copy link
Member

/unhold

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 8, 2025
Copy link

ti-chi-bot bot commented Jul 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 9, 2025
@AilinKid
Copy link
Contributor

AilinKid commented Jul 9, 2025

/retest-required

Copy link

ti-chi-bot bot commented Jul 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-08 02:33:29.806526389 +0000 UTC m=+1967062.529705366: ☑️ agreed by hawkingrei.
  • 2025-07-09 15:11:29.807943839 +0000 UTC m=+2098942.531122820: ☑️ agreed by AilinKid.

@AilinKid
Copy link
Contributor

/retest-required

@AilinKid
Copy link
Contributor

AilinKid commented Jul 12, 2025

local test can succeed for TestQ22, unit test is ok

@AilinKid
Copy link
Contributor

/retest-required

@AilinKid
Copy link
Contributor

/test unit-test

Copy link

tiprow bot commented Jul 12, 2025

@AilinKid: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fixdb
Copy link
Contributor

fixdb commented Jul 14, 2025

/retest

@hawkingrei hawkingrei force-pushed the cherry-pick-61196-to-release-8.5 branch from 83f754e to 6f19c98 Compare July 14, 2025 00:25
@hawkingrei
Copy link
Member

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

hawkingrei and others added 7 commits July 14, 2025 11:17
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei force-pushed the cherry-pick-61196-to-release-8.5 branch from 6f19c98 to f942210 Compare July 14, 2025 02:18
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
Copy link
Member

/retest

Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot merged commit a67a7b3 into pingcap:release-8.5 Jul 14, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants