-
Notifications
You must be signed in to change notification settings - Fork 6k
planner: predicate simplification when to push down predicate with join | tidb-test=pr/2520 #61316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
/retest |
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #61316 +/- ##
================================================
+ Coverage 73.1703% 74.0592% +0.8889%
================================================
Files 1726 1726
Lines 478552 482881 +4329
================================================
+ Hits 350158 357618 +7460
+ Misses 106918 103873 -3045
+ Partials 21476 21390 -86
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What problem does this PR solve?
Issue Number: close #45785
Problem Summary:
after #58962 and #58261, we have an ability to optimize the
OR
expression. But when to meetLogicalJoin
, we should optimize the condition.What changed and how does it work?
predicate simplification when to push down the predicate with join.
PPDSolver
is earlier than thePredicateSimplification
. So it is possible to better optimize the join conditions. If we implement thePredicateSimplification
forjoin
. It will have many problems. it is an example #61320Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.