executor: fix INSERT IGNORE + STRICT Mode + DST transition.

[mjonss]

What problem does this PR solve?

Issue Number: close #61439

Problem Summary:
In #61337 there was a missed case, where INSERT IGNORE and STRICT mode was combined, which resulted in not inserting a row, when it should have been adjusted and inserted.

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

When a non-existing timestamp during DST transition is used in INSERT IGNORE with STRICT sql_mode, it is now adjusted to next valid timestamp and inserted with a warning, instead of skipped or set to '0000-00-00'.

[tiprow]

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Copilot]

Pull Request Overview

This PR fixes the behavior when combining INSERT IGNORE with STRICT mode during a DST transition by adjusting the erroneous timestamp and ensuring the row is inserted with a warning instead of being skipped.

• Added integration tests to verify the correct behavior.
• Updated expected test outputs in result files.
• Adjusted error handling logic in pkg/executor/insert_common.go to give IGNORE precedence over STRICT mode.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
tests/integrationtest/t/executor/insert.test	Added integration test for INSERT IGNORE with DST transition case.
tests/integrationtest/r/executor/insert.result	Updated expected result output for the new behavior.
pkg/executor/insert_common.go	Changed error handling logic to account for ignore flag priority.

Comments suppressed due to low confidence (1)

pkg/executor/insert_common.go:329

• [nitpick] Consider renaming 'ignoreErr' to a more descriptive name such as 'shouldIgnoreError' to clarify its purpose in determining whether to convert errors to warnings.

if !e.ignoreErr && e.Ctx().GetSessionVars().SQLMode.HasStrictMode() {

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.6095%. Comparing base (fbf1586) to head (f86cae7).
Report is 238 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #61440        +/-   ##
================================================
+ Coverage   73.1533%   73.6095%   +0.4562%     
================================================
  Files          1727       1729         +2     
  Lines        479773     482535      +2762     
================================================
+ Hits         350970     355192      +4222     
+ Misses       107279     105851      -1428     
+ Partials      21524      21492        -32     

Flag	Coverage Δ
integration	42.3893% <100.0000%> (?)
unit	72.4894% <100.0000%> (+0.0704%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.7804% <ø> (ø)
parser	∅ <ø> (∅)
br	47.3111% <ø> (-0.1406%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[hawkingrei]

/ok-to-test

[YangKeao]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Defined2014,YangKeao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-05-31 00:50:21.359153089 +0000 UTC m=+57307.561498339: ☑️ agreed by Defined2014.
• 2025-06-03 02:24:48.422451297 +0000 UTC m=+322174.624796562: ☑️ agreed by YangKeao.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #62304.
But this PR has conflicts, please resolve them!