Skip to content

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jun 5, 2025

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

use slices.Sort to simple code

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Jun 5, 2025
@hawkingrei hawkingrei added the skip-issue-check Indicates that a PR no need to check linked issue. label Jun 5, 2025
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.5463%. Comparing base (f4989a6) to head (bed5064).
Report is 2 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61505        +/-   ##
================================================
+ Coverage   73.0972%   73.5463%   +0.4490%     
================================================
  Files          1729       1729                
  Lines        480683     480697        +14     
================================================
+ Hits         351366     353535      +2169     
+ Misses       107765     105631      -2134     
+ Partials      21552      21531        -21     
Flag Coverage Δ
integration 42.4314% <100.0000%> (?)
unit 72.4182% <100.0000%> (+0.0558%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 46.9629% <ø> (-0.0053%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 5, 2025
Copy link

ti-chi-bot bot commented Jun 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 5, 2025
Copy link

ti-chi-bot bot commented Jun 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-05 04:02:04.772851882 +0000 UTC m=+500810.975197147: ☑️ agreed by qw4990.
  • 2025-06-05 04:58:03.174300593 +0000 UTC m=+504169.376645858: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit ac812ca into pingcap:master Jun 5, 2025
24 checks passed
@hawkingrei hawkingrei deleted the planner_sort branch June 5, 2025 05:56
joechenrh pushed a commit to joechenrh/tidb that referenced this pull request Jun 10, 2025
AilinKid pushed a commit to AilinKid/tidb that referenced this pull request Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants