-
Notifications
You must be signed in to change notification settings - Fork 6k
ddl: fix a bug that index with empty name can be created unexpectedly #61531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #61531 +/- ##
================================================
+ Coverage 73.0963% 74.9789% +1.8825%
================================================
Files 1729 1751 +22
Lines 480686 489395 +8709
================================================
+ Hits 351364 366943 +15579
+ Misses 107793 99477 -8316
- Partials 21529 22975 +1446
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/retest |
/retest |
Co-authored-by: tangenta <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fzzf678, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-8.5 |
@CbcWestwolf: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #61265
Problem Summary:
If a duplicate name index is found with
IF NOT EXISTS
, tidb report a warningtidb/pkg/ddl/executor.go
Lines 4715 to 4718 in 0d8e2bb
but do not skip the following execution
tidb/pkg/ddl/executor.go
Lines 4915 to 4920 in 0d8e2bb
What changed and how does it work?
If a duplicate name index is found, skip the following execution.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.