types/time: invalid timestamp during DST spring forward fixed to next valid ts instead of zero date.

[mjonss]

What problem does this PR solve?

Issue Number: close #61335

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[tiprow]

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mjonss]

/retest

[mjonss]

/retest

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.5834%. Comparing base (5343560) to head (0b32a08).
Report is 149 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #61533        +/-   ##
================================================
+ Coverage   73.0870%   73.5834%   +0.4964%     
================================================
  Files          1730       1730                
  Lines        481184     481217        +33     
================================================
+ Hits         351683     354096      +2413     
+ Misses       107956     105617      -2339     
+ Partials      21545      21504        -41     

Flag	Coverage Δ
integration	42.4101% <88.8888%> (?)
unit	72.4278% <88.8888%> (+0.0996%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.7804% <ø> (ø)
parser	∅ <ø> (∅)
br	46.9933% <ø> (+0.0183%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[qw4990]

A nice fix! Could you add more test cases like :

1. where column date_add(<invalid_time>, interval 1 day)
2. where date_add(column, interval 1 day) <invalid_time>

[mjonss]

/retest

[mjonss]

/retest

[dveeden]

I assume timestamp and timestamp(6) are expected to behave the same?

[mjonss]

Yes. I just tested manually and it is the same, but would prefer to not include timestamp(6) in this test. I am currently working on a more covering tests for timestamp, which also includes timestamp with fractions, which should cover this as well.

[dveeden]

mysql-8.0.11-TiDB-v9.0.0-alpha-892-gb79cae3387-dirty> show warnings;
+---------+------+--------------------------------------------------------------------------------------------------------------------------------+
| Level   | Code | Message                                                                                                                        |
+---------+------+--------------------------------------------------------------------------------------------------------------------------------+
| Warning | 8179 | Timestamp is not valid, since it is in Daylight Saving Time transition '{2025 3 30 2 30 0 0}' for time zone 'Europe/Amsterdam' |
| Warning | 8179 | Timestamp is not valid, since it is in Daylight Saving Time transition '{2025 3 30 2 30 0 0}' for time zone 'Europe/Amsterdam' |
| Warning | 8179 | Timestamp is not valid, since it is in Daylight Saving Time transition '{2025 3 30 2 30 0 0}' for time zone 'Europe/Amsterdam' |
+---------+------+--------------------------------------------------------------------------------------------------------------------------------+
3 rows in set (0.000 sec)

This warning:

• Is TiDB specific
• Is similar to the 1292 "Incorrect datetime value..." warning in MySQL
• Is more specific to what is wrong with the supplied value
• Has a timestamp format that is different than what the user supplied or what is usual for MySQL
• Was not added in this PR

I would prefer to keep things as similar to MySQL as possible. However the added info here is useful.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dveeden, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dveeden,qw4990]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2025-06-12 12:51:14.722876636 +0000 UTC m=+532252.951191898: ☑️ agreed by qw4990.
• 2025-06-16 13:22:00.586965231 +0000 UTC m=+105173.310144213: ☑️ agreed by dveeden.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-8.5: #62265.
But this PR has conflicts, please resolve them!