-
Notifications
You must be signed in to change notification settings - Fork 6k
ddl: fix cancelling stuck issue during adding index #61544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix cancelling stuck issue during adding index #61544
Conversation
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #61544 +/- ##
================================================
+ Coverage 73.0942% 75.0322% +1.9380%
================================================
Files 1729 1752 +23
Lines 480715 492003 +11288
================================================
+ Hits 351375 369161 +17786
+ Misses 107793 99790 -8003
- Partials 21547 23052 +1505
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CbcWestwolf, fzzf678, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: tangenta <[email protected]>
What problem does this PR solve?
Issue Number: close #61087
Problem Summary:
The
getChunk()
stuck issue has been solved by #57468, which changed the chunk pool implementation from channel to async.Pool
.What changed and how does it work?
This PR only adds the test to make sure that there will be no regression in the future.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.