Skip to content

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jun 6, 2025

What problem does this PR solve?

Issue Number: close #61087

Problem Summary:

The getChunk() stuck issue has been solved by #57468, which changed the chunk pool implementation from channel to a sync.Pool.

What changed and how does it work?

This PR only adds the test to make sure that there will be no regression in the future.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 6, 2025
Copy link

tiprow bot commented Jun 6, 2025

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.0322%. Comparing base (92925e9) to head (e7f678e).
Report is 42 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61544        +/-   ##
================================================
+ Coverage   73.0942%   75.0322%   +1.9380%     
================================================
  Files          1729       1752        +23     
  Lines        480715     492003     +11288     
================================================
+ Hits         351375     369161     +17786     
+ Misses       107793      99790      -8003     
- Partials      21547      23052      +1505     
Flag Coverage Δ
integration 49.0678% <0.0000%> (?)
unit 72.4104% <100.0000%> (+0.0492%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 62.7803% <ø> (+15.8136%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 6, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 6, 2025
Copy link

ti-chi-bot bot commented Jun 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-06 06:32:32.211748861 +0000 UTC m=+596238.414094126: ☑️ agreed by fzzf678.
  • 2025-06-06 06:58:28.397179128 +0000 UTC m=+597794.599524393: ☑️ agreed by CbcWestwolf.

@tangenta
Copy link
Contributor Author

tangenta commented Jun 6, 2025

/approve

Copy link

ti-chi-bot bot commented Jun 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, fzzf678, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 6, 2025
@hawkingrei
Copy link
Member

/retest

1 similar comment
@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit a5f888b into pingcap:master Jun 7, 2025
27 checks passed
joechenrh pushed a commit to joechenrh/tidb that referenced this pull request Jun 10, 2025
AilinKid pushed a commit to AilinKid/tidb that referenced this pull request Jun 10, 2025
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jun 13, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 13, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #61723.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 13, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #61724.
But this PR has conflicts, please resolve them!

tangenta added a commit to ti-chi-bot/tidb that referenced this pull request Jun 19, 2025
@ti-chi-bot ti-chi-bot bot removed needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Canceling adding index job may get stuck
5 participants