Skip to content

Conversation

terry1purcell
Copy link
Contributor

@terry1purcell terry1purcell commented Jun 11, 2025

What problem does this PR solve?

Issue Number: close #62034

Problem Summary:

What changed and how does it work?

Increases the scope of variable tidb_opt_ordering_index_selectivity_ratio to apply to index joins - where the ordering is provided on the leading table of the join, but the filtering is on subsequent tables in the join query.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/planner SIG: Planner labels Jun 11, 2025
Copy link

tiprow bot commented Jun 11, 2025

Hi @terry1purcell. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@terry1purcell terry1purcell changed the title planner: extend order ratio to joins planner: extend order ratio to joins | tidb-test=pr/2530 Jun 11, 2025
@terry1purcell
Copy link
Contributor Author

/retest-required

Copy link

tiprow bot commented Jun 12, 2025

@terry1purcell: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@terry1purcell
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Jun 12, 2025
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 13, 2025
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.3633%. Comparing base (1962f22) to head (32d6e1d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61687        +/-   ##
================================================
+ Coverage   72.9246%   73.3633%   +0.4386%     
================================================
  Files          1739       1739                
  Lines        482820     482850        +30     
================================================
+ Hits         352095     354235      +2140     
+ Misses       109169     107052      -2117     
- Partials      21556      21563         +7     
Flag Coverage Δ
integration 42.3452% <100.0000%> (?)
unit 72.2026% <100.0000%> (+0.0460%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 46.3204% <ø> (-0.0154%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 17, 2025
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 28, 2025
@ti-chi-bot ti-chi-bot bot removed the approved label Jun 30, 2025
@terry1purcell terry1purcell requested a review from hawkingrei July 1, 2025 01:11
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 1, 2025
Copy link

ti-chi-bot bot commented Jul 1, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-28 15:30:26.94517626 +0000 UTC m=+1149679.668355235: ☑️ agreed by time-and-fate.
  • 2025-07-01 01:21:16.424023893 +0000 UTC m=+1357929.147202874: ☑️ agreed by hawkingrei.

Copy link

@yudongusa yudongusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also open a document PR

Copy link

ti-chi-bot bot commented Jul 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, time-and-fate, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 1, 2025
@ti-chi-bot ti-chi-bot bot merged commit 2a74539 into pingcap:master Jul 1, 2025
24 checks passed
@terry1purcell
Copy link
Contributor Author

/cherry-pick release-8.5

@ti-chi-bot
Copy link
Member

@terry1purcell: new pull request created to branch release-8.5: #62155.
But this PR has conflicts, please resolve them!

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 2, 2025
@terry1purcell terry1purcell deleted the orderjoin branch August 15, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Planner: Ordering vs filtering issue applies to index join
5 participants