-
Notifications
You must be signed in to change notification settings - Fork 6k
executor: fix nil buffer in basePartialResult4GroupConcat when hash aggregation is spilled #61808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @xzhangxian1008. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #61808 +/- ##
================================================
+ Coverage 73.0434% 73.4398% +0.3963%
================================================
Files 1730 1730
Lines 481687 481948 +261
================================================
+ Hits 351841 353942 +2101
+ Misses 108289 106465 -1824
+ Partials 21557 21541 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/run-check-issue-triage-complete |
/check-issue-triage-complete |
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dveeden, gengliqi, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #61749
Problem Summary:
What changed and how does it work?
When all values that passed in
group_concat
are null, buffer inbasePartialResult4GroupConcat
should be nil, and we need to consider it when serializing and deserializing thebasePartialResult4GroupConcat
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.