Skip to content

Conversation

xzhangxian1008
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #61749

Problem Summary:

What changed and how does it work?

When all values that passed in group_concat are null, buffer in basePartialResult4GroupConcat should be nil, and we need to consider it when serializing and deserializing the basePartialResult4GroupConcat.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue that buffer in basePartialResult4GroupConcat may be nil when hash aggregation is spilled

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/invalid-title size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2025
@xzhangxian1008 xzhangxian1008 changed the title Fix nil buffer in basePartialResult4GroupConcat when hash aggregation is spilled executor: fix nil buffer in basePartialResult4GroupConcat when hash aggregation is spilled Jun 18, 2025
Copy link

tiprow bot commented Jun 18, 2025

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 18, 2025
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4398%. Comparing base (8fc1430) to head (0bc8ad1).
Report is 97 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #61808        +/-   ##
================================================
+ Coverage   73.0434%   73.4398%   +0.3963%     
================================================
  Files          1730       1730                
  Lines        481687     481948       +261     
================================================
+ Hits         351841     353942      +2101     
+ Misses       108289     106465      -1824     
+ Partials      21557      21541        -16     
Flag Coverage Δ
integration 42.3372% <0.0000%> (?)
unit 72.2885% <100.0000%> (-0.0135%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 46.5728% <ø> (-0.0105%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 18, 2025
Copy link

ti-chi-bot bot commented Jun 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-18 09:50:04.455253969 +0000 UTC m=+265257.178432952: ☑️ agreed by XuHuaiyu.
  • 2025-06-18 12:35:09.801769393 +0000 UTC m=+275162.524948377: ☑️ agreed by dveeden.

@xzhangxian1008
Copy link
Contributor Author

/run-check-issue-triage-complete

@dveeden
Copy link
Contributor

dveeden commented Jun 19, 2025

/check-issue-triage-complete

@xzhangxian1008
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2025
Copy link

ti-chi-bot bot commented Jun 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dveeden, gengliqi, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xzhangxian1008
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2025
@ti-chi-bot ti-chi-bot bot merged commit 221d76f into pingcap:master Jun 19, 2025
24 checks passed
@xzhangxian1008 xzhangxian1008 deleted the fix-61749 branch June 19, 2025 12:46
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jul 2, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #62124.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 2, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 2, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #62125.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"parallel hash aggregation panicked" with spill data to disk
5 participants