-
Notifications
You must be signed in to change notification settings - Fork 6k
planner: fix uninit timeout for loading bindings (#61891) #61928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix uninit timeout for loading bindings (#61891) #61928
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
@hawkingrei This PR has conflicts, I have hold it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the conflict?
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei: You cannot manually add or delete the reviewing state labels, only I and the tursted members have permission to do so. In response to removing label named needs-1-more-lgtm. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #61928 +/- ##
================================================
Coverage ? 57.5557%
================================================
Files ? 1777
Lines ? 638676
Branches ? 0
================================================
Hits ? 367595
Misses ? 246922
Partials ? 24159
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/retest |
[LGTM Timeline notifier]Timeline:
|
/retest |
1 similar comment
/retest |
/test unit-test |
@AilinKid: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, hawkingrei, yudongusa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #61891
What problem does this PR solve?
Issue Number: close #61889
Problem Summary:
What changed and how does it work?
as the code show, the old code cannot init the right value for
tidb_load_binding_timeout
Currently,this switch is actually ineffective on the master branch.However,to comply with the process standards,it will still be merged into master first.But please refer to this PR for the tests.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.