-
Notifications
You must be signed in to change notification settings - Fork 6k
planner: constant folding to isnull(not null column) | tidb-test=pr/2559 #62163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: constant folding to isnull(not null column) | tidb-test=pr/2559 #62163
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
@hawkingrei This PR has conflicts, I have hold it. |
Signed-off-by: AilinKid <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #62163 +/- ##
================================================
Coverage ? 57.1849%
================================================
Files ? 1777
Lines ? 630650
Branches ? 0
================================================
Hits ? 360637
Misses ? 245839
Partials ? 24174
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, fixdb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: AilinKid <[email protected]>
Signed-off-by: AilinKid <[email protected]>
/unhold |
/test mysql-test |
@AilinKid: No presubmit jobs available for pingcap/[email protected] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
/retest |
/retest |
1 similar comment
/retest |
This is an automated cherry-pick of #62046
What problem does this PR solve?
Issue Number: close #62050 ref #7973
Problem Summary:
What changed and how does it work?
When we process the outer join, we remove the not-null flag. However, during predicate pushdown, this causes the flag to differ from the original one, and as a result, predicate simplification cannot be performed when handling the data source.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.