Skip to content

planner: RegardNULLAsPoint should be true as default #62194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jul 7, 2025
Merged

planner: RegardNULLAsPoint should be true as default #62194

merged 17 commits into from
Jul 7, 2025

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Jul 3, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #62196

Problem Summary:

What changed and how does it work?

Many system variables in the internal sql has problem that they don't rightly init the system variable to the default value.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4177%. Comparing base (0fd4b17) to head (42185b3).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #62194        +/-   ##
================================================
+ Coverage   72.9018%   73.4177%   +0.5158%     
================================================
  Files          1750       1750                
  Lines        484502     484571        +69     
================================================
+ Hits         353211     355761      +2550     
+ Misses       109666     107276      -2390     
+ Partials      21625      21534        -91
Flag Coverage Δ
integration 42.3754% <100.0000%> (?)
unit 72.2945% <100.0000%> (+0.1313%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7804% <ø> (ø)
parser ∅ <ø> (∅)
br 46.3502% <ø> (+0.0255%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added the sig/planner SIG: Planner label Jul 4, 2025
@hawkingrei
Copy link
Member Author

/retest

1 similar comment
@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 4, 2025
@hawkingrei hawkingrei force-pushed the RegardNULLAsPoint branch from ccbf618 to 4166ddb Compare July 4, 2025 23:32
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei hawkingrei force-pushed the RegardNULLAsPoint branch from 1c20804 to 03a63dc Compare July 7, 2025 02:38
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2025
hawkingrei added 8 commits July 7, 2025 13:28
@hawkingrei
planner: RegardNULLAsPoint should be true as default
6b14b1a 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
0a9b12d 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
d9824ca 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
5d93b39 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
04847b5 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
e364c37 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
8577f6a 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
6782359 
Signed-off-by: Weizhen Wang <[email protected]>
hawkingrei added 2 commits July 7, 2025 13:37
@hawkingrei
update
8382226 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
update
cee2b06 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 7, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 7, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-04 14:54:08.816549083 +0000 UTC m=+1665901.539728065: ☑️ agreed by winoros.
  • 2025-07-07 05:02:22.537103166 +0000 UTC m=+1889595.260282141: ☑️ agreed by AilinKid.

@hawkingrei
update
3c839aa 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, winoros, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 7, 2025
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
update
42185b3 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
Copy link
Member Author

/retest

2 similar comments
@hawkingrei
Copy link
Member Author

/retest

@hawkingrei
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit d87ec2b into pingcap:master Jul 7, 2025
27 checks passed
@hawkingrei
Copy link
Member Author

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 7, 2025
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#62194
bf39575 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-7.5: #62261.
But this PR has conflicts, please resolve them!

In response to this:

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 7, 2025
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 7, 2025
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#62194
c7be6d7 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.1: #62262.
But this PR has conflicts, please resolve them!

In response to this:

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 7, 2025
Open
13 tasks
@ti-chi-bot
Copy link
Member

@hawkingrei: new pull request created to branch release-8.5: #62263.
But this PR has conflicts, please resolve them!

In response to this:

/cherrypick release-8.5
/cherrypick release-8.1
/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jul 7, 2025
@hawkingrei @ti-chi-bot
This is an automated cherry-pick of pingcap#62194
439c1d8 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 7, 2025
Merged
13 tasks
breezewish added a commit to breezewish/tidb that referenced this pull request Jul 9, 2025
@breezewish
Merge commit '5ec4f36c855574b64be98e4c9f6b4485ceb4143d' into wenxuan/…
00f1ba5 
…fix-scalar-func-init

* commit '5ec4f36c855574b64be98e4c9f6b4485ceb4143d': (48 commits)
  dxf: use correct store in add-index, checksum by copr in import-into, and enable DXF service (pingcap#62224)
  infoschema: Add new fields in tiflash system table (pingcap#62296)
  lightning: fix panic on checksum manager close when checksum is off (pingcap#62300)
  *: Add owners cfg file for pkg/metrics module (pingcap#62292)
  autoid: reserve a table ID range for downstream fork (pingcap#62157)
  planner: Fix expression rewriting and method signature mismatch in plan cache (pingcap#58506)
  planner: use prop based noCopPushDown mechanism to replace aggregation field. (pingcap#62249)
  fix: close issue 59457 by trim compare first (pingcap#61915)
  planner: add skew risk ratio for range pred (pingcap#62035)
  meta: unify definition of system or memory DB name (pingcap#62247)
  ddl: add retry for updateSelfVersion (pingcap#62190)
  *: upgrade client go to add config valid function (pingcap#62246)
  executor: fix the inappropriate RequiredRows set by `TopNExec` (pingcap#62154)
  planner: RegardNULLAsPoint should be true as default (pingcap#62194)
  planner: apply predicate simplification before extract condition (pingcap#62211)
  test: fix failed test caused by new version of `mc` (pingcap#61356)
  planner: deprecate the logical interface CanPushToCop and its implementation canPushToCopImpl. (pingcap#62235)
  fix: shut down test without error (pingcap#61921)
  planner: lift the canPushToCop check of logical join/window/selection (pingcap#62206)
  backend/local: add rate limiter for split region and ingest data (pingcap#61555)
  ...
hawkingrei added a commit to ti-chi-bot/tidb that referenced this pull request Jul 9, 2025
@hawkingrei
This is an automated cherry-pick of pingcap#62194
ba1ce34 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot bot pushed a commit that referenced this pull request Jul 14, 2025
@ti-chi-bot
planner: RegardNULLAsPoint should be true as default (#62194) (#62263)
c6468fb 
close #62196
ti-chi-bot bot pushed a commit that referenced this pull request Jul 15, 2025
@ti-chi-bot
planner: RegardNULLAsPoint should be true as default (#62194) (#62261)
4d1cf01 
close #62196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@AilinKid AilinKid AilinKid approved these changes

+1 more reviewer

@yudongusa yudongusa yudongusa approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong RegardNULLAsPoint value in the interal sql
5 participants
@hawkingrei @ti-chi-bot @winoros @AilinKid @yudongusa