Skip to content

test: wait for statistics owner to close on exit #62198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 4, 2025
Merged

test: wait for statistics owner to close on exit #62198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b1060c
test: wait stats owner to be closed in test
tangenta Jul 3, 2025
3569728
refine
tangenta Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pkg/domain/domain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2078,6 +2078,13 @@ func (do *Domain) gcStatsWorkerExitPreprocessing() {
do.statsOwner.Close()
ch <- struct{}{}
}()
if intest.InTest {
// We should wait for statistics owner to close on exit.
// Otherwise, the goroutine leak detection may fail.
<-ch
logutil.BgLogger().Info("gcStatsWorker exit preprocessing finished")
return
}
select {
case <-ch:
logutil.BgLogger().Info("gcStatsWorker exit preprocessing finished")
Expand Down