types: fix CASE WHEN wrong result when prepare value is NULL #62568

yihong0618 · 2025-07-23T03:18:40Z

What problem does this PR solve?

This patch close 62564 by fixing the case when prepare NULL value when case when
prepare, and do not break the json value ref #54145

Issue Number: close #62564

Problem Summary:

What changed and how does it work?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: yihong0618 <[email protected]>

ti-chi-bot · 2025-07-23T03:18:50Z

Hi @yihong0618. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

tiprow · 2025-07-23T03:18:58Z

Hi @yihong0618. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hawkingrei · 2025-07-23T03:29:11Z

/ok-to-test

Signed-off-by: yihong0618 <[email protected]>

codecov · 2025-07-23T04:12:55Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.3763%. Comparing base (e823930) to head (94ab0ae).
⚠️ Report is 56 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #62568        +/-   ##
================================================
+ Coverage   72.8667%   73.3763%   +0.5095%     
================================================
  Files          1762       1769         +7     
  Lines        486020     496757     +10737     
================================================
+ Hits         354147     364502     +10355     
- Misses       110216     110327       +111     
- Partials      21657      21928       +271

Flag	Coverage Δ
integration	`42.3217% <100.0000%> (?)`
unit	`72.2008% <100.0000%> (+0.0853%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`52.8700% <ø> (+0.0896%)`	⬆️
parser	`∅ <ø> (∅)`
br	`46.0212% <ø> (-0.3169%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pkg/planner/core/casetest/tiflash_predicate_push_down_test.go

Signed-off-by: yihong0618 <[email protected]>

hawkingrei · 2025-07-28T08:40:46Z

/check-issue-triage-complete

YangKeao

Rest LGTM

pkg/planner/core/casetest/integration_test.go

hawkingrei

LGTM, I test this PR with fuzz tools and don't find the new bug.

hawkingrei · 2025-07-28T09:12:45Z

/hold

waiting for the other's approve

Signed-off-by: yihong0618 <[email protected]>

YangKeao

LGTM

ti-chi-bot · 2025-07-28T10:43:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [YangKeao,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

YangKeao · 2025-07-28T10:43:16Z

/unhold

ti-chi-bot · 2025-07-28T10:43:21Z

[LGTM Timeline notifier]

Timeline:

2025-07-28 08:58:50.778682263 +0000 UTC m=+257539.245245050: ☑️ agreed by hawkingrei.
2025-07-28 10:43:19.643315325 +0000 UTC m=+263808.109878101: ☑️ agreed by YangKeao.

hawkingrei · 2025-07-28T10:49:47Z

/unhold

…#62568) close pingcap#62564

ddl: fix CASE WHEN wrong result when prepare value is NULL

f43b2de

Signed-off-by: yihong0618 <[email protected]>

ti-chi-bot bot added do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner labels Jul 23, 2025

ti-chi-bot bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 23, 2025

ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jul 23, 2025

fix: bazel changed

31bf0fa

Signed-off-by: yihong0618 <[email protected]>

lance6716 changed the title ~~ddl: fix CASE WHEN wrong result when prepare value is NULL~~ types: fix CASE WHEN wrong result when prepare value is NULL Jul 27, 2025

lance6716 requested a review from Lloyd-Pottiger July 27, 2025 13:27

Lloyd-Pottiger reviewed Jul 28, 2025

View reviewed changes

pkg/planner/core/casetest/tiflash_predicate_push_down_test.go Outdated Show resolved Hide resolved

fix: address tests

732e26a

Signed-off-by: yihong0618 <[email protected]>

ti-chi-bot bot removed do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked labels Jul 28, 2025

YangKeao self-requested a review July 28, 2025 08:43

YangKeao reviewed Jul 28, 2025

View reviewed changes

pkg/planner/core/casetest/integration_test.go Outdated Show resolved Hide resolved

hawkingrei approved these changes Jul 28, 2025

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 28, 2025

hawkingrei requested a review from Lloyd-Pottiger July 28, 2025 09:12

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2025

fix: using integration test address comments

94ab0ae

Signed-off-by: yihong0618 <[email protected]>

YangKeao approved these changes Jul 28, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 28, 2025

ti-chi-bot bot merged commit 312226f into pingcap:master Jul 28, 2025
27 checks passed

JaySon-Huang pushed a commit to JaySon-Huang/tidb that referenced this pull request Aug 10, 2025

types: fix CASE WHEN wrong result when prepare value is NULL (pingcap…

82edf74

…#62568) close pingcap#62564

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

types: fix CASE WHEN wrong result when prepare value is NULL #62568

types: fix CASE WHEN wrong result when prepare value is NULL #62568

Uh oh!

yihong0618 commented Jul 23, 2025 •

edited by hawkingrei

Loading

Uh oh!

ti-chi-bot bot commented Jul 23, 2025

Uh oh!

tiprow bot commented Jul 23, 2025

Uh oh!

hawkingrei commented Jul 23, 2025

Uh oh!

codecov bot commented Jul 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

hawkingrei commented Jul 28, 2025

Uh oh!

YangKeao left a comment

Uh oh!

Uh oh!

hawkingrei left a comment

Uh oh!

hawkingrei commented Jul 28, 2025

Uh oh!

YangKeao left a comment

Uh oh!

ti-chi-bot bot commented Jul 28, 2025

Uh oh!

YangKeao commented Jul 28, 2025

Uh oh!

ti-chi-bot bot commented Jul 28, 2025

Uh oh!

hawkingrei commented Jul 28, 2025

Uh oh!

Uh oh!

Uh oh!

types: fix CASE WHEN wrong result when prepare value is NULL #62568

types: fix CASE WHEN wrong result when prepare value is NULL #62568

Uh oh!

Conversation

yihong0618 commented Jul 23, 2025 • edited by hawkingrei Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Uh oh!

ti-chi-bot bot commented Jul 23, 2025

Uh oh!

tiprow bot commented Jul 23, 2025

Uh oh!

hawkingrei commented Jul 23, 2025

Uh oh!

codecov bot commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

hawkingrei commented Jul 28, 2025

Uh oh!

YangKeao left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hawkingrei left a comment

Choose a reason for hiding this comment

Uh oh!

hawkingrei commented Jul 28, 2025

Uh oh!

YangKeao left a comment

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot bot commented Jul 28, 2025

Uh oh!

YangKeao commented Jul 28, 2025

Uh oh!

ti-chi-bot bot commented Jul 28, 2025

[LGTM Timeline notifier]

Uh oh!

hawkingrei commented Jul 28, 2025

Uh oh!

Uh oh!

Uh oh!

yihong0618 commented Jul 23, 2025 •

edited by hawkingrei

Loading

codecov bot commented Jul 23, 2025 •

edited

Loading