Skip to content

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Aug 5, 2025

close #60047

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2025
Copy link

tiprow bot commented Aug 5, 2025

Hi @xhebox. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xhebox xhebox changed the title table: use writable columns to avoid columns not match when add colum… table: use writable columns to avoid columns not match when add column DDL exec parallel with update DML (#60048) Aug 5, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 5, 2025
Copy link

ti-chi-bot bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,tangenta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 5, 2025
Copy link

ti-chi-bot bot commented Aug 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-05 09:40:17.519916804 +0000 UTC m=+347527.662677980: ☑️ agreed by tangenta.
  • 2025-08-05 09:40:28.778731076 +0000 UTC m=+347538.921492252: ☑️ agreed by Defined2014.

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-6.5-20250805-v6.5.12@db45d0f). Learn more about missing BASE report.

Additional details and impacted files
@@                        Coverage Diff                        @@
##             release-6.5-20250805-v6.5.12     #62835   +/-   ##
=================================================================
  Coverage                                ?   73.6586%           
=================================================================
  Files                                   ?       1098           
  Lines                                   ?     353676           
  Branches                                ?          0           
=================================================================
  Hits                                    ?     260513           
  Misses                                  ?      76433           
  Partials                                ?      16730           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot merged commit 02cdb71 into pingcap:release-6.5-20250805-v6.5.12 Aug 5, 2025
10 checks passed
@xhebox xhebox deleted the f3 branch August 5, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants