Skip to content

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Aug 6, 2025

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

This PR makes DXF use a separate session pool, to avoid other components put bad sessions to the pool and make DXF report errors.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2025
Copy link

tiprow bot commented Aug 6, 2025

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: tangenta <[email protected]>
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.7440%. Comparing base (8aa5f5f) to head (8536bcc).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #62855        +/-   ##
================================================
+ Coverage   72.8149%   74.7440%   +1.9290%     
================================================
  Files          1789       1838        +49     
  Lines        487036     499466     +12430     
================================================
+ Hits         354635     373321     +18686     
+ Misses       110776     102968      -7808     
- Partials      21625      23177      +1552     
Flag Coverage Δ
integration 48.7765% <100.0000%> (?)
unit 72.1745% <100.0000%> (-0.0075%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 63.0932% <ø> (+16.7639%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.


do.crossKSSessMgr = crossks.NewManager()
if kerneltype.IsClassic() || keyspace.IsRunningOnSystem() {
do.dxfSessionPool = createInternelSessionPool(dxfSessionPoolSize, factory)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can create it directly, if it's not used, there is no cost

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 6, 2025
@tangenta tangenta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2025
Copy link

ti-chi-bot bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 6, 2025
Copy link

ti-chi-bot bot commented Aug 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-06 09:36:32.941841794 +0000 UTC m=+433703.084602970: ☑️ agreed by D3Hunter.
  • 2025-08-06 09:45:12.934951238 +0000 UTC m=+434223.077712403: ☑️ agreed by wjhuang2016.

Signed-off-by: tangenta <[email protected]>
Signed-off-by: tangenta <[email protected]>
@tangenta tangenta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2025
Copy link

ti-chi-bot bot commented Aug 7, 2025

@tangenta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
non-block/pull-unit-test-next-gen 617cb60 link false /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Aug 7, 2025

/test build pull-build-next-gen

Copy link

tiprow bot commented Aug 7, 2025

@wuhuizuo: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test build pull-build-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 8acfef8 into pingcap:master Aug 7, 2025
25 checks passed
@D3Hunter D3Hunter mentioned this pull request Aug 12, 2025
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants