Skip to content

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Aug 20, 2025

What problem does this PR solve?

Issue Number: close #63089

Problem Summary:
prevent br from becoming ddl owner

What changed and how does it work?

prevent br from becoming ddl owner

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2025
Copy link

tiprow bot commented Aug 20, 2025

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Jianjun Liao <[email protected]>
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.7393%. Comparing base (2010151) to head (c84894e).
⚠️ Report is 50 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #63090        +/-   ##
================================================
+ Coverage   72.8040%   74.7393%   +1.9353%     
================================================
  Files          1821       1839        +18     
  Lines        494529     496713      +2184     
================================================
+ Hits         360037     371240     +11203     
+ Misses       112638     102898      -9740     
- Partials      21854      22575       +721     
Flag Coverage Δ
integration 46.1546% <100.0000%> (?)
unit 72.4887% <75.0000%> (+0.2210%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 63.1532% <100.0000%> (+16.8587%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 20, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 21, 2025
Copy link

ti-chi-bot bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 21, 2025
Copy link

ti-chi-bot bot commented Aug 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-20 07:42:03.966550874 +0000 UTC m=+425731.909726380: ☑️ agreed by lance6716.
  • 2025-08-21 11:57:07.347190686 +0000 UTC m=+527435.290366202: ☑️ agreed by BornChanger.

@BornChanger
Copy link
Contributor

/retest

Copy link

tiprow bot commented Aug 21, 2025

@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit ec36da2 into pingcap:master Aug 21, 2025
38 of 45 checks passed
@Leavrth Leavrth added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Aug 28, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 28, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #63246.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 28, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #63247.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 28, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #63248.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 28, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #63249.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Aug 28, 2025
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #63250.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent br from becoming ddl owner
5 participants