Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #63155

What problem does this PR solve?

Issue Number: ref #61702

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

apply below diff

code diff
diff --git a/pkg/store/copr/coprocessor.go b/pkg/store/copr/coprocessor.go
index 28eaaeef54..2dcbe28f19 100644
--- a/pkg/store/copr/coprocessor.go
+++ b/pkg/store/copr/coprocessor.go
@@ -1421,6 +1421,10 @@ func (worker *copIteratorWorker) handleTaskOnce(bo *Backoffer, task *copTask) (*
 		req.ReplicaReadType = options.GetTiKVReplicaReadType(kv.ReplicaReadFollower)
 		ops = append(ops, tikv.WithMatchStores([]uint64{*task.redirect2Replica}))
 	}
+	if req.InputRequestSource != "internal_DistTask" && req.InputRequestSource != "internal_others" &&
+		req.InputRequestSource != "internal_ddl" && req.InputRequestSource != "internal_stats" && req.InputRequestSource != "internal_DDLNotifier" {
+		fmt.Printf("cop request source: %+v\n", req.InputRequestSource)
+	}
 	resp, rpcCtx, storeAddr, err := worker.kvclient.SendReqCtx(bo.TiKVBackoffer(), req, task.region,
 		timeout, getEndPointType(task.storeType), task.storeAddr, ops...)
 	err = derr.ToTiDBErr(err)

then start nextgen, and import with import into t from '/minio/a.csv';

cop request source: internal_ImportInto

then we do add index with multiple schema change alter table t add index ia1(id), add index ia2(id), add index ia3(id);

cop request source: internal_ddl_add_index
cop request source: internal_ddl_add_index_ddl
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20250815 labels Aug 25, 2025
@ti-chi-bot
Copy link
Member Author

@D3Hunter This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

Copy link

ti-chi-bot bot commented Aug 25, 2025

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 26, 2025
@D3Hunter
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2025
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 26, 2025
Copy link

ti-chi-bot bot commented Aug 26, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-26 02:07:56.950250353 +0000 UTC m=+233168.828081307: ☑️ agreed by D3Hunter.
  • 2025-08-26 02:14:37.577805321 +0000 UTC m=+233569.455636295: ☑️ agreed by Benjamin2037.

Copy link

ti-chi-bot bot commented Aug 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Benjamin2037, D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 26, 2025
@ti-chi-bot ti-chi-bot bot merged commit 473b87d into pingcap:release-nextgen-20250815 Aug 26, 2025
5 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-63155-to-release-nextgen-20250815 branch August 26, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20250815
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants