Skip to content

br: prevent br from becoming ddl owner (#63090) #63249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2025
Merged

br: prevent br from becoming ddl owner (#63090) #63249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac19edc
This is an automated cherry-pick of #63090
Leavrth Aug 21, 2025
e109e49
resolve conflicts
Leavrth Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions br/cmd/br/backup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,6 @@ func NewBackupCommand() *cobra.Command {
// Do not run stat worker in BR.
session.DisableStats4Test()

// Do not run ddl worker in BR.
config.GetGlobalConfig().Instance.TiDBEnableDDL.Store(false)

summary.SetUnit(summary.BackupUnit)
return nil
},
Expand Down
4 changes: 4 additions & 0 deletions br/cmd/br/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (

"github.com/pingcap/log"
"github.com/pingcap/tidb/br/pkg/utils"
"github.com/pingcap/tidb/pkg/config"
"github.com/spf13/cobra"
"go.uber.org/zap"
)
Expand All @@ -22,6 +23,9 @@ func main() {
}
DefineCommonFlags(rootCmd)
SetDefaultContext(ctx)

config.GetGlobalConfig().Instance.TiDBEnableDDL.Store(false)

rootCmd.AddCommand(
NewDebugCommand(),
NewBackupCommand(),
Expand Down
Loading