Skip to content

expression: add cast for eq expr when doing constant propagation | tidb-test=pr/2592 #63327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 4, 2025
+130 −1
Merged

expression: add cast for eq expr when doing constant propagation | tidb-test=pr/2592 #63327

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3e6d4f1
expression: add cast expr for eq when doing constant propagation
guo-shaoge Sep 2, 2025
70c45a9
fix
guo-shaoge Sep 2, 2025
81e754c
fix
guo-shaoge Sep 2, 2025
663bac8
fix
guo-shaoge Sep 2, 2025
629d921
fix
guo-shaoge Sep 2, 2025
14a14f0
refine
guo-shaoge Sep 3, 2025
1745510
refine
guo-shaoge Sep 3, 2025
f865b65
fix
guo-shaoge Sep 3, 2025
3b3fea9
refine
guo-shaoge Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/expression/constant_propagation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,12 @@ func (s *propConstSolver) pickNewEQConds(visited []bool) (retMapper map[int]*Con
return nil
}
if updated {
retMapper[s.getColID(col)] = con
newExpr := BuildCastFunction(s.ctx, con, col.GetType(s.ctx.GetEvalCtx()))
newCon, ok := newExpr.(*Constant)
if !ok {
logutil.BgLogger().Info("gjt2")
}
retMapper[s.getColID(col)] = newCon
}
}
return
Expand Down