Skip to content

Conversation

ekexium
Copy link
Member

@ekexium ekexium commented Sep 2, 2025

What problem does this PR solve?

Issue Number: close #63343

Problem Summary:
Fix failing tests in next-gen mode by adding appropriate kernel type checks and skipping incompatible tests.

What changed and how does it work?

  1. readcommitted_test.go: Added next-gen kernel checks to skip TestFailedDMLConsistency1 and TestFailedDMLConsistency2 because next-gen hangs when acquiring pessimistic locks after failed DML with fair locking disabled
  2. data_feature_usage_test.go:
    • Added kernel type check in TestTxnUsageInfo to only test fair locking settings in classic mode
    • Added skip for TestFairLockingUsage in next-gen mode since fair locking is not yet supported

These changes prevent test failures and hangs in next-gen environment while maintaining full test coverage in classic mode.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-triage-completed do-not-merge/needs-tests-checked labels Sep 2, 2025
@ekexium ekexium requested a review from wuhuizuo September 2, 2025 13:02
Copy link

codecov bot commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.2120%. Comparing base (3d9a0eb) to head (0793616).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #63342        +/-   ##
================================================
+ Coverage   72.7832%   73.2120%   +0.4287%     
================================================
  Files          1832       1832                
  Lines        495794     496096       +302     
================================================
+ Hits         360855     363202      +2347     
+ Misses       113010     110997      -2013     
+ Partials      21929      21897        -32     
Flag Coverage Δ
integration 42.0368% <ø> (?)
unit 72.2581% <ø> (+0.0061%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 46.5294% <ø> (-0.0026%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 3, 2025
Signed-off-by: ekexium <[email protected]>
@ekexium ekexium requested a review from hawkingrei September 3, 2025 03:13
Copy link

ti-chi-bot bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 3, 2025
Copy link

ti-chi-bot bot commented Sep 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-03 01:44:17.604837937 +0000 UTC m=+922949.482668891: ☑️ agreed by zyguan.
  • 2025-09-03 03:20:05.418619703 +0000 UTC m=+928697.296450647: ☑️ agreed by hawkingrei.

@ti-chi-bot ti-chi-bot bot merged commit feba12d into pingcap:master Sep 3, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix txn-related tests for next-gen in CI
3 participants