-
Notifications
You must be signed in to change notification settings - Fork 6k
test: fix some tests for next-gen #63342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: ekexium <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #63342 +/- ##
================================================
+ Coverage 72.7832% 73.2120% +0.4287%
================================================
Files 1832 1832
Lines 495794 496096 +302
================================================
+ Hits 360855 363202 +2347
+ Misses 113010 110997 -2013
+ Partials 21929 21897 -32
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: ekexium <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawkingrei, zyguan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #63343
Problem Summary:
Fix failing tests in next-gen mode by adding appropriate kernel type checks and skipping incompatible tests.
What changed and how does it work?
TestFailedDMLConsistency1
andTestFailedDMLConsistency2
because next-gen hangs when acquiring pessimistic locks after failed DML with fair locking disabledTestTxnUsageInfo
to only test fair locking settings in classic modeTestFairLockingUsage
in next-gen mode since fair locking is not yet supportedThese changes prevent test failures and hangs in next-gen environment while maintaining full test coverage in classic mode.
Check List
Tests
Side effects
Documentation
Release note