Skip to content

Conversation

ekexium
Copy link
Member

@ekexium ekexium commented Sep 3, 2025

What problem does this PR solve?

Issue Number: close #63343

Problem Summary:

Fix next-gen CI.

What changed and how does it work?

This PR fixes or skips some failed tests in next-gen CI

GC Worker tests (pkg/store/gcworker/):

  • TestGCWithPendingTxn
  • TestLeaderTick
  • TestPrepareGC
  • TestRunGCJob
  • TestSkipGCAndOnlyResolveLock

Coprocessor tests (pkg/store/copr/):

  • Fixed region boundary handling for keyspace-aware keys in NextGen mode
  • Added proper keyspace encoding using store codec

Session transaction tests (pkg/sessiontxn/):

  • TestFailedDMLConsistency1 and TestFailedDMLConsistency2 (require fair locking)
  • Fixed TestOptimisticTxnRetryInPessimisticMode configuration

Other test fixes:

  • Helper tests: proper keyspace encoding for region boundaries
  • Telemetry tests: skip fair locking tests in NextGen mode
  • Global system variable initialization fix for TiDBTxnAssertionLevel

All tests use kerneltype.IsNextGen() check with clear skip messages explaining the incompatibility reason.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Sep 3, 2025
@ekexium ekexium changed the title tests: skip NextGen incompatible tests across multiple packages test: fix or skip some failed next-gen tests Sep 3, 2025
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Sep 3, 2025

/test pull-unit-test-next-gen

Copy link

tiprow bot commented Sep 3, 2025

@wuhuizuo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-unit-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.7274%. Comparing base (3d9a0eb) to head (570fad1).
⚠️ Report is 29 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #63355        +/-   ##
================================================
+ Coverage   72.7832%   73.7274%   +0.9442%     
================================================
  Files          1832       1833         +1     
  Lines        495794     501158      +5364     
================================================
+ Hits         360855     369491      +8636     
+ Misses       113010     109985      -3025     
+ Partials      21929      21682       -247     
Flag Coverage Δ
integration 42.6678% <66.6666%> (?)
unit 72.8371% <66.6666%> (+0.5850%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 46.5498% <ø> (+0.0177%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Sep 4, 2025

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 4, 2025
Copy link

ti-chi-bot bot commented Sep 4, 2025

@ekexium: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
non-block/pull-unit-test-next-gen 570fad1 link false /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ekexium ekexium requested a review from hawkingrei September 4, 2025 08:50
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 5, 2025
Copy link

ti-chi-bot bot commented Sep 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-04 03:24:50.838962198 +0000 UTC m=+63834.822059646: ☑️ agreed by zyguan.
  • 2025-09-05 12:25:35.608342414 +0000 UTC m=+18602.168223901: ☑️ agreed by cfzjywxk.

Copy link

ti-chi-bot bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, yudongusa, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 5, 2025
@ti-chi-bot ti-chi-bot bot merged commit 5810837 into pingcap:master Sep 5, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix txn-related tests for next-gen in CI
5 participants