-
Notifications
You must be signed in to change notification settings - Fork 6k
ddl: fix dynamic parameter adjustment failure in txn and local ingest mode (#63605) #63674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: fix dynamic parameter adjustment failure in txn and local ingest mode (#63605) #63674
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
@fzzf678 This PR has conflicts, I have hold it. |
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/unhold |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #63674 +/- ##
================================================
Coverage ? 57.8057%
================================================
Files ? 1783
Lines ? 632937
Branches ? 0
================================================
Hits ? 365874
Misses ? 242341
Partials ? 24722
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, fzzf678 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #63605
What problem does this PR solve?
Issue Number: close #63201
Problem Summary:
After #60828, the
runReorgJob
will return periodically, this means every time we enter therunOneJobStep
, theJob
is a new job, not the one pass to backfill worker, so the config in the initialJob
can't be updated.tidb/pkg/ddl/job_worker.go
Lines 898 to 900 in b3011b6
What changed and how does it work?
Update config from system table in the adjust config loop.
Check List
Tests
After this pr, use
admin alter ddl jobs
can adjustthread
batch_size
andmax_write_speed
normallySide effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.