Skip to content

executor, types: fix bug of insert into unsigned float/double (#6939) #6940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2018
Merged

executor, types: fix bug of insert into unsigned float/double (#6939) #6940

merged 1 commit into from
Jul 2, 2018

Conversation

XuHuaiyu
Copy link
Contributor

cherry-pick #6939

@XuHuaiyu
Copy link
Contributor Author

PTAL @zz-jason @winoros

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@coocood
Copy link
Member

coocood commented Jun 29, 2018

WARNING: DATA RACE
Read at 0x00c42013cfb8 by goroutine 45:
github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop.func1()
/home/jenkins/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/domain/domain.go:562 +0x1f6

@shenli
Copy link
Member

shenli commented Jun 29, 2018

@tiancaiamao Is the data race issue fixed in master?

@shenli shenli added the type/bugfix This PR fixes a bug. label Jun 29, 2018
@tiancaiamao
Copy link
Contributor

I'm not sure, the CI log is gone. @shenli @coocood

@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Jul 2, 2018

/run-unit-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@coocood
Copy link
Member

coocood commented Jul 2, 2018

LGTM

@coocood coocood added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Jul 2, 2018
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Jul 2, 2018

PTAL @zz-jason

zz-jason
zz-jason approved these changes Jul 2, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit b74990f into pingcap:release-2.0 Jul 2, 2018
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XuHuaiyu @coocood @shenli @tiancaiamao @zz-jason