executor: speed up replace into statement #7027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-all-tests |
|
/rebuild |
|
/run-all-tests tidb-test=pr/570 |
|
/run-unit-test |
coocood
reviewed
Jul 11, 2018
executor/replace.go
Outdated
| if err != nil { | ||
| return errors.Trace(err) | ||
| } | ||
| err = e.Table.RemoveRecord(e.ctx, handle, oldRow) |
There was a problem hiding this comment.
If the row is unchanged, we don't need to remove the row and insert it again.
shenli
reviewed
Jul 11, 2018
executor/batch_checker.go
Outdated
| @@ -249,3 +249,29 @@ func (b *batchChecker) deleteDupKeys(row toBeCheckedRow) { | |||
| delete(b.dupKVs, string(uk.newKV.key)) | |||
| } | |||
| } | |||
|
|
|||
| // decodeOldRow decodes the table record row from storage for batch check. | |||
| func (b *batchChecker) decodeOldRow(ctx sessionctx.Context, t table.Table, handle int64) (types.DatumRow, error) { | |||
There was a problem hiding this comment.
s/decodeOldRow/getCurrentRow/ or getOldRow
executor/replace.go
Outdated
| @@ -44,7 +46,51 @@ func (e *ReplaceExec) Open(ctx context.Context) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (e *ReplaceExec) exec(rows []types.DatumRow) error { | |||
| func (e *ReplaceExec) removeRow(handle int64, newRow types.DatumRow) error { | |||
There was a problem hiding this comment.
Add comments for removeRow and insertRow.
|
@jackysp PTAL the comments |
|
LGTM |
|
/run-all-tests |
zz-jason
added
status/LGT1
|
PTAL @coocood |
coocood
reviewed
Jul 16, 2018
executor/replace.go
Outdated
| } | ||
|
|
||
| for i, r := range e.toBeCheckedRows { | ||
| for { |
There was a problem hiding this comment.
Can we extract the inner for loop into its own function.
It's hard to see where the code is going to execute after break and continute.
|
PTAL @coocood |
|
PTAL @coocood |
zimulala
reviewed
Jul 17, 2018
executor/replace.go
Outdated
| return h, nil | ||
| } | ||
|
|
||
| // replaceRow remove all duplicate rows for one row, then insert it. |
There was a problem hiding this comment.
s/remove/removes
s/insert/inserts
|
PTAL @zimulala |
zimulala
added
status/LGT2
|
/run-all-tests |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed? (mandatory)
Speed up
replace intostatement.What are the type of the changes (mandatory)?
How has this PR been tested (mandatory)?
Unit tests and manual tests.
Benchmark result if necessary (optional)
This pr(port 4000) is nearly 10x faster than master(port 5000).
PTAL @coocood @zimulala