Skip to content

Conversation

coocood
Copy link
Member

@coocood coocood commented Jul 11, 2018

What have you changed? (mandatory)

make make the set system variable log shorter.

What is the type of the changes? (mandatory)

  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which is an improvement to an existing feature)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this PR been tested? (mandatory)

Manual

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

Does this PR affect tidb-ansible update? (mandatory)

Does this PR need to be added to the release notes? (mandatory)

Refer to a related PR or issue link (optional)

cherry-pick #7029

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@coocood
Copy link
Member Author

coocood commented Jul 11, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@coocood
Copy link
Member Author

coocood commented Jul 11, 2018

@tiancaiamao @zz-jason PTAL

@zz-jason
Copy link
Member

LGTM

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added type/2.0 cherry-pick status/LGT2 Indicates that a PR has LGTM 2. labels Jul 11, 2018
@coocood coocood merged commit 8438bad into pingcap:release-2.0 Jul 11, 2018
@coocood coocood deleted the shorter-log-2.0 branch July 11, 2018 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants