Skip to content

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Jul 25, 2018

What have you changed? (mandatory)

Cherry-pick from #7142

What is the type of the changes? (mandatory)

  • Bug fix (non-breaking change which fixes an issue)

How has this PR been tested? (mandatory)

ut

Does this PR affect documentation (docs/docs-cn) update? (mandatory)

no

Does this PR affect tidb-ansible update? (mandatory)

no

Does this PR need to be added to the release notes? (mandatory)

Yes: fix a bug that we miss adding last handle index in some case.

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Add a few positive/negative examples (optional)

@winkyao winkyao added type/bugfix This PR fixes a bug. type/2.0 cherry-pick priority/release-blocker This issue blocks a release. Please solve it ASAP. labels Jul 25, 2018
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 25, 2018
@winkyao
Copy link
Contributor Author

winkyao commented Jul 25, 2018

/run-all-tests tikv=release-2.0 tidb-test=release-2.0

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 25, 2018
Copy link
Contributor

@ciscoxll ciscoxll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is clear, LGTM.

@ciscoxll ciscoxll added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 25, 2018
@winkyao winkyao merged commit 183671b into pingcap:release-2.0 Jul 25, 2018
@winkyao winkyao deleted the cherry-pick-2.0 branch July 25, 2018 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants