Skip to content

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Aug 28, 2018

(cherry picked from commit 09fb68a)

What problem does this PR solve?

Cherry-pick #7485 to release 2.0.

What is changed and how it works?

Append an empty slice instead of nil when appending a parameter.

Check List

Tests

  • Integration test

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

Related changes

  • Need to be included in the release note

@jackysp
Copy link
Member Author

jackysp commented Aug 28, 2018

/run-all-tests tikv=release-2.0 pd=release-2.0 tidb-test=release-2.0

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood
Copy link
Member

coocood commented Aug 28, 2018

LGTM

@shenli
Copy link
Member

shenli commented Aug 28, 2018

/run-all-tests tikv=release-2.0 pd=release-2.0 tidb-test=release-2.0

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 28, 2018
@ngaut ngaut merged commit d677534 into pingcap:release-2.0 Aug 28, 2018
@jackysp jackysp deleted the send-long-data branch September 7, 2018 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mysql-protocol status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants