Skip to content

Conversation

zz-jason
Copy link
Member

What problem does this PR solve?

cherry pick #7806 to release 2.0

What is changed and how it works?

Check List

Tests

  • Unit test

Related changes

  • Need to be included in the release note

@zz-jason
Copy link
Member Author

@winkyao @eurekaka PTAL

@zz-jason
Copy link
Member Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@eurekaka
Copy link
Contributor

/run-unit-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 15, 2018
@zz-jason zz-jason merged commit 0b4762c into pingcap:release-2.0 Oct 15, 2018
@zz-jason zz-jason deleted the cherrypick/2.0/7806 branch October 15, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants