Skip to content

stats: fix panic caused by empty histogram (#7912) #7928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2018
Merged

stats: fix panic caused by empty histogram (#7912) #7928

merged 1 commit into from
Oct 17, 2018

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Oct 17, 2018

What problem does this PR solve?

Cherry pick #7912

What is changed and how it works?

Cherry pick #7912

Check List

Tests

  • Unit test

Code changes

  • Has unexported function/method change

Side effects

  • None

Related changes

  • None

@alivxxx
Copy link
Contributor Author

alivxxx commented Oct 17, 2018

/run-all-tests

eurekaka
eurekaka reviewed Oct 17, 2018
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 17, 2018
XuHuaiyu
XuHuaiyu approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 17, 2018
@zz-jason zz-jason merged commit c91290f into pingcap:release-2.1 Oct 17, 2018
@alivxxx alivxxx deleted the empty-histogram branch October 17, 2018 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

Assignees
No one assigned
Labels
component/statistics status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alivxxx @eurekaka @XuHuaiyu @zz-jason