Skip to content

Fix TimestampColumn fail in ASan/TSan #10142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

Fix TimestampColumn fail in ASan/TSan #10142

merged 2 commits into from
Apr 30, 2025

Conversation

windtalker
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #6233

Problem Summary:
#10136 try to fix the test, but failed.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@windtalker
save work
1e9db9a 
Signed-off-by: xufei <[email protected]>
@windtalker
save work
743be2d 
Signed-off-by: xufei <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2025
@windtalker
Copy link
Contributor Author

/run-sanitizer-test asan

@windtalker windtalker changed the title Fix test fail in ASan/TSan Fix TimestampColumn fail in ASan/TSan Apr 30, 2025
@windtalker
Copy link
Contributor Author

ASan test result: https://ci.pingcap.net/blue/organizations/jenkins/tiflash-sanitizer-daily/detail/tiflash-sanitizer-daily/2614/pipeline

JaySon-Huang
JaySon-Huang approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, wshwsh12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,wshwsh12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 30, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 30, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-30 05:08:56.049484335 +0000 UTC m=+1023479.861274717: ☑️ agreed by wshwsh12.
  • 2025-04-30 05:08:59.579522811 +0000 UTC m=+1023483.391313192: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot merged commit 1d01837 into pingcap:master Apr 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@windtalker @JaySon-Huang @wshwsh12