Skip to content

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented May 6, 2025

What problem does this PR solve?

Issue Number: close #10145

Problem Summary:

apple clang does not support std::vector::append_range. The master branch use llvm 17 under macos (#9572), so does not affected by this issue.

What is changed and how it works?

*: fix darwin build
   use `std::vector::insert` instead

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: Lloyd-Pottiger <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 6, 2025
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 6, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label May 6, 2025
Copy link
Contributor

ti-chi-bot bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,JaySon-Huang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 6, 2025
Copy link
Contributor

ti-chi-bot bot commented May 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-06 08:30:51.664889023 +0000 UTC m=+343898.847792275: ☑️ agreed by CalvinNeo.
  • 2025-05-06 08:38:31.300601958 +0000 UTC m=+344358.483505217: ☑️ agreed by JaySon-Huang.

@JaySon-Huang JaySon-Huang changed the title *: fix darwin build *: fix darwin build under apple clang May 6, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 6, 2025
@ti-chi-bot ti-chi-bot bot merged commit ebb0431 into pingcap:release-8.5 May 6, 2025
4 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the fix-darwin-build-8.5 branch May 6, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants